Bug: Layouts don't save default text size correctly

Page 1 of 1 (10 items)
This post has 9 Replies | 0 Followers

Posts 13342
Forum MVP
Mark Barnes | Forum Activity | Posted: Fri, Nov 26 2010 12:00 PM | Locked

When you change the default text size in program settings, all the panels that are currently set to default will have their text size change. Panels not currently set to default don't change. This is perfect. Great!

However this goes wrong if you restore from a layout. Here's how to reproduce:

  • Have 4 panels open.
  • Set the text size to 80% in one of them, and to default in the others (default marked by the larger vertical bar on the slider).
  • Change the default text size in program settings to 120%. All of the panels will change to the new default of 120% - except the one that was at non-default. So far, so good.
  • Now save that as a layout. The layout should save one panel at 80%, and three panels at default. But it doesn't. It saves one panel at 80% and three panels at 120%.
  • So, now change the default text size in program settings to 100%.
  • Restore the layout. You should get 1 panel at 80% and three panels at the new default of 100%. But you don't. The three panels are 'stuck' at 120%.

So the point is: when saving layouts, Logos shouldn't hard-code the text size if the text size is set to 'default'.

Posts 4077
Melissa Snyder | Forum Activity | Replied: Mon, Nov 29 2010 11:19 AM | Locked

Mark Barnes:
  • Now save that as a layout. The layout should save one panel at 80%, and three panels at default. But it doesn't. It saves one panel at 80% and three panels at 120%.
  • But 120% is the new default, so it seems to me it is doing the correct thing. 

    Mark Barnes:
  • Restore the layout. You should get 1 panel at 80% and three panels at the new default of 100%. But you don't. The three panels are 'stuck' at 120%.
  • This does appear to be a bug--they should be at the current default size. I'll report this.

    Posts 725
    Harry Hahne | Forum Activity | Replied: Wed, Dec 1 2010 4:08 PM | Locked

    Melissa Snyder:
    120% is the new default

    It would be helpful if the font slider in the Panel menu had a clear spot indicating the default size and/or a Reset Default Size button.

    It is also not clear to me why 120% would be default, rather than 100%. Since the default font size for the program is arbitrarily determined by the programmers, you could simply use a larger font at set the default scaling to 100%.

    Posts 24837
    Forum MVP
    Dave Hooton | Forum Activity | Replied: Wed, Dec 1 2010 4:38 PM | Locked

    Harry Hahne:
    It would be helpful if the font slider in the Panel menu had a clear spot indicating the default size and/or a Reset Default Size button.

    The default position has larger vertical bars than the others (the third one from left in my panels, where default is 100% in Settings).

    Dave
    ===

    Windows & Android

    Posts 13342
    Forum MVP
    Mark Barnes | Forum Activity | Replied: Thu, Dec 2 2010 12:50 AM | Locked

    Harry Hahne:
    It is also not clear to me why 120% would be default, rather than 100%.

    The default is set in Program Settings. In the scenario I was outlining above, I had changed the default in program settings from 100% to 120%.

    Posts 18651
    Rosie Perera | Forum Activity | Replied: Thu, Dec 2 2010 2:38 AM | Locked

    Melissa Snyder:

    Mark Barnes:

  • Now save that as a layout. The layout should save one panel at 80%, and three panels at default. But it doesn't. It saves one panel at 80% and three panels at 120%.
  •  

    But 120% is the new default, so it seems to me it is doing the correct thing. 

    Mark Barnes:

  • Restore the layout. You should get 1 panel at 80% and three panels at the new default of 100%. But you don't. The three panels are 'stuck' at 120%.
  • This does appear to be a bug--they should be at the current default size. I'll report this.

    The first part is not "doing the correct thing" -- if it were, then the three panels wouldn't be restored to 120%; they'd be restored to whatever the current default is, which in this case is 100%. So it seems to be hard coding the 120% when it saves the layout, rather than saving those three panels as "default".

    Posts 4077
    Melissa Snyder | Forum Activity | Replied: Thu, Dec 2 2010 8:41 AM | Locked

    Rosie Perera:

    The first part is not "doing the correct thing" -- if it were, then the three panels wouldn't be restored to 120%; they'd be restored to whatever the current default is, which in this case is 100%. So it seems to be hard coding the 120% when it saves the layout, rather than saving those three panels as "default".

    He hadn't restored the layout at that point--he had just created it and saved it, and at the time, he had one panel he had manually changed to 80% and the three panels left at default, which at the time was 120%; so three panels at 120% at that point was correct. 

    However, I agreed with Mark that once he changed the default back to 100% and loaded the saved layout, the three panels should have returned to 100%. This has been filed as a bug.

    Posts 103
    Mark | Forum Activity | Replied: Thu, Dec 2 2010 8:58 AM | Locked

    I think this issue is relevant to the discussion, if not my apologies Mark.

    My experience with layouts, which I like the concept very much, still is lacking in at least three important ways.  Perhaps there are workarounds to these issues that I am unaware of.  In any event, I would like layouts improved by:

    (a) "Locking" them to prevent accidental deletion.  I have a nasty tendency to delete unnecessary layouts (those constantly being created by Logos) before closing most sessions.  I occasionally delete a useful one that I have setup and given a name.  I realize this is completely the fault of the user; however, a confirmation of "locked" layouts would prevent this from happening.  Otherwise, an option to have Logos stop creating layouts would be another solution.

    (b) A more robust manner in sorting/organizing saved (named) layouts would encourage me to create even more layouts.

    (c) And more related to the discussion at hand, when creating layouts have text size stay with that particular layout instead of the resource.  For example, in a reading layout I prefer a larger font size for the comfort of reading larger quantity of text.  However, what happens, for me at least, is that Bible used in the layout is universally changed to the larger text size when using Logos with other layouts.  The exact same thing occurs when displaying an interlinear.  I wish to make some interlinear layouts but any Bibles used in such layouts will be displayed that way everywhere.

    Sorry I realize these are more suggestions than bugs.

    Regards

    Posts 18651
    Rosie Perera | Forum Activity | Replied: Thu, Dec 2 2010 1:28 PM | Locked

    Melissa Snyder:

    Rosie Perera:

    The first part is not "doing the correct thing" -- if it were, then the three panels wouldn't be restored to 120%; they'd be restored to whatever the current default is, which in this case is 100%. So it seems to be hard coding the 120% when it saves the layout, rather than saving those three panels as "default".

     

    He hadn't restored the layout at that point--he had just created it and saved it, and at the time, he had one panel he had manually changed to 80% and the three panels left at default, which at the time was 120%; so three panels at 120% at that point was correct. 

    However, I agreed with Mark that once he changed the default back to 100% and loaded the saved layout, the three panels should have returned to 100%. This has been filed as a bug.

    Not wanting to be a nitpicker, but yeah I guess I am a nitpicker. He wasn't complaining about the fact that his panels were still showing three at 120% at the time, he just meant that it was at that time in the process that the mistake occurred internally. Notice that he didn't say "The layout should have one panel at 80%, and three panels at default." He said "The layout should save one panel at 80%, and three panels at default. But it doesn't. It saves one panel at 80% and three panels at 120%. They'd look the same in the layout at that point whether they were saved internally as 120% or "default" because at that time the default was 120%, so the visual isn't the problem. The problem is the internal saved state of the layout which then is why it gets restored improperly later on.

    Posts 13342
    Forum MVP
    Mark Barnes | Forum Activity | Replied: Thu, Dec 2 2010 2:00 PM | Locked

    Yes, it's a matter of cause and effect. The problem is almost certainly caused at the saving stage, but the effect is only seen at the restore stage.

    Page 1 of 1 (10 items) | RSS