Longstanding Bug: Can't add non-Bibles to "Add Version" in search results.

Mark Barnes
Mark Barnes Member Posts: 15,432 ✭✭✭

This was first report in 2010, but it's still a really frustrating problem. It doesn't seem like it would be difficult to fix, but it would make a big difference to the usefulness of morph searches, particularly those initiated from the Bible Word Study.

Put simply, the bug is this: it's not possible to choose non-Bibles from the "Add Versions" dropdown, even though there are many, many morphologically tagged resources that are not Bibles.

In an ideal world, it would obviously be great if the Add Versions button only gave resources that could be used as parallel resources to the references found in the search results, but I appreciate that might be technically difficult to implement without dragging the performance down.

But surely it's possible just to allow any resource to be added?

(I know there's an issue here in that this picker - which is borrowed from Bible Search and Text Comparison - allows you to choose multiple versions, whereas the normal picker only allows you to choose one version. But personally, if there was to be a restriction on morph searches, I would rather the restriction be that we're limited to one version. Those who wanted multiple Bible versions could always flick to the Bible search.)

This is my personal Faithlife account. On 1 March 2022, I started working for Faithlife, and have a new 'official' user account. Posts on this account shouldn't be taken as official Faithlife views!

Comments

  • Dave Hooton
    Dave Hooton Member, MVP Posts: 35,672 ✭✭✭

    For Morph search use the same picker as for the main resource as this lists collections of, and open resources that are, non-bibles and has  "All Morph Resources" in place of "All Bibles"

    Dave
    ===

    Windows 11 & Android 13

  • Dave Hooton
    Dave Hooton Member, MVP Posts: 35,672 ✭✭✭

    For Morph search use the same picker as for the main resource as this lists collections of, and open resources that are, non-bibles and has  "All Morph Resources" in place of "All Bibles"

    To clarify. My response was a suggestion/fix for Logos to implement.

    Dave
    ===

    Windows 11 & Android 13

  • Angela Murashov
    Angela Murashov Member Posts: 1,532

    Put simply, the bug is this: it's not possible to choose non-Bibles from the "Add Versions" dropdown, even though there are many, many morphologically tagged resources that are not Bibles

    This will be fixed in 5.1b Beta 1. 

  • Mark Barnes
    Mark Barnes Member Posts: 15,432 ✭✭✭

    This will be fixed in 5.1b Beta 1. 

    Although you can now add non-Bibles, they're not displaying results properly, as the screenshots below suggest:

    This resource doesn't show up at all:

    And this one uses a different datatype in the first and second columns:

    This is my personal Faithlife account. On 1 March 2022, I started working for Faithlife, and have a new 'official' user account. Posts on this account shouldn't be taken as official Faithlife views!

  • Dylan Rondeau
    Dylan Rondeau Member, Logos Employee Posts: 1,401

    Although you can now add non-Bibles, they're not displaying results properly

    I have created a new case for this issue.

    Dylan Rondeau, Software Tester

    Enable Logging: Mac | Windows (Right-click "Save As...")

  • Dylan Rondeau
    Dylan Rondeau Member, Logos Employee Posts: 1,401

    Any news on when this will be fixed?

    It's slated for an upcoming release, but I don't have an estimate on when that will ship. We haven't lost track of it, don't worry. [:)]

    Dylan Rondeau, Software Tester

    Enable Logging: Mac | Windows (Right-click "Save As...")

  • Angela Murashov
    Angela Murashov Member Posts: 1,532

    Any news on when this will be fixed?

    It's slated for an upcoming release, but I don't have an estimate on when that will ship. We haven't lost track of it, don't worry. Smile

    This should be fixed in 5.2b beta 4. [:)]

  • Mark Barnes
    Mark Barnes Member Posts: 15,432 ✭✭✭

    This is my personal Faithlife account. On 1 March 2022, I started working for Faithlife, and have a new 'official' user account. Posts on this account shouldn't be taken as official Faithlife views!

  • Dave Hooton
    Dave Hooton Member, MVP Posts: 35,672 ✭✭✭

    The menu hasn't been fixed, so you still have to type the title. There is no improvement AFAIK! (I can't test the Works of Josephus or Philo as I don't have the Greek versions).

    Dave
    ===

    Windows 11 & Android 13

  • Bradley Grainger (Logos)
    Bradley Grainger (Logos) Administrator, Logos Employee Posts: 11,955

    The menu hasn't been fixed, so you still have to type the title.

    I don't understand what this means; can you elaborate? (The word "menu" doesn't occur previously in this thread, so I couldn't tell if you were referring to a previously-discussed issue.)

  • Dave Hooton
    Dave Hooton Member, MVP Posts: 35,672 ✭✭✭

    I don't understand what this means; can you elaborate? (The word "menu" doesn't occur previously in this thread

    The resource "picker" still doesn't show "All Morph Resources"

    Dave
    ===

    Windows 11 & Android 13

  • Bradley Grainger (Logos)
    Bradley Grainger (Logos) Administrator, Logos Employee Posts: 11,955
  • Dave Hooton
    Dave Hooton Member, MVP Posts: 35,672 ✭✭✭

    Dave
    ===

    Windows 11 & Android 13

  • Mark Barnes
    Mark Barnes Member Posts: 15,432 ✭✭✭

    Thanks for doing this. I can confirm that the first book is indeed fixed. However the second bug remains. Please don't forget about that.

    I said earlier that the second bug is that the two columns often use different datatypes. Actually that's not quite right. The bug instead is that the first resource is displaying the wrong information, regardless of whether the second resource is shown, or not.

    image

    In that screenshot, the left hand column finds a result in Antiquities 1.2. But it's actually displaying the results only from line seven, not from the whole section. Worse, in an AND search, it will only find results where the two words appear in the same line, not when they appear in the same 'verse'.

    This is my personal Faithlife account. On 1 March 2022, I started working for Faithlife, and have a new 'official' user account. Posts on this account shouldn't be taken as official Faithlife views!

  • Bradley Grainger (Logos)
    Bradley Grainger (Logos) Administrator, Logos Employee Posts: 11,955

    But it's actually displaying the results only from line seven, not from the whole section. Worse, in an AND search, it will only find results where the two words appear in the same line, not when they appear in the same 'verse'.

    Correct: the indexer is incorrectly dividing the resources into "verses" whenever it reaches a new Volume/Page/Line milestone.

    This will be fixed in the next beta (not Beta 5). Unfortunately, because it's an indexer issue, not a resource issue, you will have to "rebuild indexes" to get the fix.

  • Mark Barnes
    Mark Barnes Member Posts: 15,432 ✭✭✭

    This will be fixed in the next beta

    That was quick! Thanks!!

    This is my personal Faithlife account. On 1 March 2022, I started working for Faithlife, and have a new 'official' user account. Posts on this account shouldn't be taken as official Faithlife views!

  • Dylan Rondeau
    Dylan Rondeau Member, Logos Employee Posts: 1,401

    This will be fixed in the next beta

    That was quick! Thanks!!

    This is in 5.2b Beta 6. [:)]

    Dylan Rondeau, Software Tester

    Enable Logging: Mac | Windows (Right-click "Save As...")

  • Don Awalt
    Don Awalt Member Posts: 3,521 ✭✭✭
  • Bradley Grainger (Logos)
    Bradley Grainger (Logos) Administrator, Logos Employee Posts: 11,955

    Does this require us to "Rebuild Index"?

    Unfortunately, yes, that is currently the only way to get the fix.

  • Don Awalt
    Don Awalt Member Posts: 3,521 ✭✭✭

    If you follow my attempt to sequentially get two additional resources showing here, I think you'll see that this requires several extra redundant keystrokes and is losing information I have already set up.

    I did the search query Mark started, then added Josephus(Greek), click inside the Add Versions box and click the right arrow, and get this, which is correct:

    then I click into the Add Versions box (twice - first click highlights the existing resource name), add a comma, then type Joseph so I can pick Josephus New Updated edition. I select that entry, they are both in the Add Versions box. What do I do now? If I click the right arrow, it goes back to just my first selection only in the Add Versions box. If I click up on the lemma choice and hit that right arrow, Add Versions clears and nothing is there. 

    So then I try, with the original search query only displayed in 1 resource:

    1. Click in the Add Versions box, (sometimes you have to click again as the first version is highlighted [if your cursor was off that panel], sometimes not!), type comma, Jos, click to select the revised Josephus - it now LEAVES that box, and now highlights the lemma search term! Not intuitive.

    2. Click back in the Add Versions box, and everything is highlighted. So you have to click in the search box TWICE - once to remove the highlighting on the terms, the second time to actually say Go), now you have a search with just two resources, the original and the third, and the Add Versions box just says "Josephus" in it!

    At this point if I just click on "Josephus" in the Add Versions box I get a generic drop down - it seems to have lost the fact I am looking for a Josephus resource.

    So the only way to get all three resources showing that I can figure out is you have to start with an empty Add Versions box, and type Joseph, click twice, add comma, type Joseph, select the next resource, click twice on the arrow, and then it comes up.

    I would vote that this needs to be made a lot more efficient in keystrokes, and bulletproof. Does anyone else see/experience these challenges as I do?

  • Dave Hooton
    Dave Hooton Member, MVP Posts: 35,672 ✭✭✭

    I did the search query Mark started, then added Josephus(Greek), click inside the Add Versions box and click the right arrow, and get this, which is correct:

    then I click into the Add Versions box (twice - first click highlights the existing resource name), add a comma, then type Joseph so I can pick Josephus New Updated edition. I select that entry, they are both in the Add Versions box. What do I do now? If I click the right arrow, it goes back to just my first selection only in the Add Versions box.

    Which makes me wonder if this was ever tested - this happens whether one types part of the second resource as you indicate, or simply selects it from the picker. The software should assume that a comma actually means that I am adding a resource and not replacing one.

    Dave
    ===

    Windows 11 & Android 13