Bug: Context menu acts on the wrong version Bible Grid Search

Mark Barnes
Mark Barnes Member Posts: 15,432 ✭✭✭

Most context menu options work on the wrong Bible version in Bible Grid Search. They work on a verse from your prioritised version, not from the version selected and displayed.

To reproduce:

  1. Run a Bible search in your Top Bibles.
  2. Right-click on a 'box' that's not from your preferred version.
  3. Select reference from the right-hand side of the context menu. Note that the reference gives the name of the version you clicked on (NKJV in the example below).
  4. Choose Copy Isaiah 10:2 (or whatever) from the left hand side.
  5. Paste the result.

Actual result:

  • You get the Bible verse from the default version, not the version you had selected.

Expected result:

  • You get the Bible verse from the selected version.
  • For comparison, you should repeat the same operation from within a Bible. There you will see that the behaviour works as expected.

Additional notes:

  • Open, Open in a New Tab and Visual Copy is also affected. Search works correctly, however.

This is my personal Faithlife account. On 1 March 2022, I started working for Faithlife, and have a new 'official' user account. Posts on this account shouldn't be taken as official Faithlife views!

Comments

  • Jack Caviness
    Jack Caviness MVP Posts: 13,594

    To reproduce:

    1. Run a Bible search in your Top Bibles.
    2. Right-click on a 'box' that's not from your preferred version.
    3. Select reference from the right-hand side of the context menu.

    May I add an additional bug? Right click in the Mac version is inoperative. Nothing happens. (6.5 Beta 3; Mac OS 10.10.4)

  • Bradley Grainger (Logos)
    Bradley Grainger (Logos) Administrator, Logos Employee Posts: 12,086

    This is kind of a "working as designed" feature that's manifesting itself in a confusing (and potentially undesirable) way.

    The "Reference" item on the context menu always acts on your top KeyLink destination, even if (or even though) the reference is from some other versification scheme. This is generally a very good feature of the software: right-clicking on a "Ps 3:2 (BHS)" reference then selecting "Reference" and "Copy" will copy Ps 3:1 from your English Bible; it's not hard-coded to always use a BHS. Similarly, in your example, the selected reference from the NKJV versification (not translation) is converted to the versemap of your preferred Bible, looked up in your preferred KeyLink destination, then copied.

    IIRC, we discovered and looked into fixing this, but found that it would be non-trivial.

  • Mark Barnes
    Mark Barnes Member Posts: 15,432 ✭✭✭

    The "Reference" item on the context menu always acts on your top KeyLink destination, even if (or even though) the reference is from some other versification scheme.

    I don't say this very often, but I think you're wrong about this, at least in regards to Copy and Visual Copy. For those items the behaviour in grid search is different from the behaviour in Bibles. (You're  right about Open/Open in a New Tab. I was wrong about this because I have advanced prioritisation set up, which was changing the default behaviour.)

    I understand that usually all Bible datatypes are mapped to your default Bible. So if I click on a Bible reference in The Greek-English Lexicon of the Septuagint, my top prioritised Bible will open. I know that I won't automatically get a Septuagint just because the reference was using the Septuagint Bible datatype. That's fine.

    But that's not what I'm reporting here, because the Bible Grid search isn't just working from datatypes, it's working from resources. The square doesn't indicate that a word has been found in a datatype, but in a resource. If I hover over the square, it doesn't show me the text of my most highly prioritised Bible (like the Lexicon did), it correctly shows me the text of the Bible version indicated. That's different to the lexicon (which shows me my default Bible). The lexicon is what I call a datatype link (logosref:BibleLXX2.Joe2.17), whereas the search appears to be what I call a resource link (logosres:nkjv;ref=BibleNKJV.Joe2.14), if you see what I mean, which is why I believe the behaviour should be different to the lexicon.

    And digging into this a bit further reveals a further inconsistency.

    • In a Bible, Copy/Visual Copy from the Milestone reference will copy the text from the current version.
    • In a Bible, Copy/Visual Copy from a cross-reference will copy the text from the current version. But if you hover over the same reference it will show the text from the default version!
    • In a Bible Search, Copy/Visual Copy from the search result will copy the text from the default version. But if you hover over the same reference it will show the text from the current version!

    It's this inconsistency that suggests it's a bug.

    I'm sure this isn't a priority for any of you. But the pedantic in me would prefer a "won't fix" to "not a bug"!

    This is my personal Faithlife account. On 1 March 2022, I started working for Faithlife, and have a new 'official' user account. Posts on this account shouldn't be taken as official Faithlife views!

  • Bradley Grainger (Logos)
    Bradley Grainger (Logos) Administrator, Logos Employee Posts: 12,086

    the Bible Grid search isn't just working from datatypes, it's working from resources

    In theory, yes. In implementation, no.

    which is why I believe the behaviour should be different to the lexicon

    I wasn't arguing that the current behaviour was correct.

    I was just attempting to explain why it works the way it does.

  • Bradley Grainger (Logos)
    Bradley Grainger (Logos) Administrator, Logos Employee Posts: 12,086

    But the pedantic in me would prefer a "won't fix" to "not a bug"

    I never said it wasn't a bug. I even said we "looked into fixing this" (emphasis added). So, for clarity: this is currently a "won't fix" bug. [:)]

  • Mark Barnes
    Mark Barnes Member Posts: 15,432 ✭✭✭

    I never said it wasn't a bug. I even said we "looked into fixing this" (emphasis added). So, for clarity: this is currently a "won't fix" bug. Smile

    Thank you [:)].

    This is my personal Faithlife account. On 1 March 2022, I started working for Faithlife, and have a new 'official' user account. Posts on this account shouldn't be taken as official Faithlife views!