Bug: 4.0c Beta 1: Edit a tag on multiple books at once adds a second tag with the new text, leaving

Rosie Perera
Rosie Perera Member Posts: 26,194 ✭✭✭✭✭

Open Library
Select multiple books that have no tags yet
Click "add tag" and type "A" to add a simple tag to all of them at once
Click the edit pencile next to this new tag you've just added, and change the text to "B"

Result: it adds a new tag "B" to all of the selected items but does not remove the previous one "A"

Expect  it to edit the "A" tag and change it to "B" so you're left with just one tag still

Comments

  • Dave Hooton
    Dave Hooton MVP Posts: 36,308

    Click "add tag" and type "A" to add a simple tag to all of them at once

    That's below the heading that states "Add these tags to all"?  Because it is acting literally and treating "B" as a new tag.

    I got caught with wanting to Clear tags, knowing it would clear EVERY tag value, in order to replace them with a new tag value. As soon as I cleared them the books disappeared from the Library list and I had to select them manually, hoping I would remember all13 resources!  It was also acting literally because I had selected them based on the value of the original tag.

    So these library functions are very CRUDE and dangerous. I would suggest:

    • the Info panel display every tag value on the multiple resources followed by add tag, as per a single resource being selected.
    • changing a tag affects only the resources having that value whilst adding one affects every resource selected and a new add
      tag slot appears.
    • the resources remain listed until the Info panel is closed!

    Dave
    ===

    Windows 11 & Android 13

  • Rosie Perera
    Rosie Perera Member Posts: 26,194 ✭✭✭✭✭


    Click "add tag" and type "A" to add a simple tag to all of them at once

    That's below the heading that states "Add these tags to all"?  Because it is acting literally and treating "B" as a new tag.


    Yes, I click "add tag" below "Add these tags to all" ; I don't think it's acting literally on purpose. I think there's just some bug in the way the function works.

    When you've got multiple resources selected, clicking the edit pencil to edit the "A" and change it to "B" is doing the same thing as if you clicked "add tag" and added a second tag "B":

    Before:

    image

    After editing with pencil icon:

    image (but...this is deceptive; the A tag isn't really gone)

    You have to go look at each individual book's info panel to see that A is still there because it doesn't show up in the multiple resources info panel:

    image

    If I do the same thing when only one book is selected, it properly edits the A tag to B and does not add a new one.

    Before:

    image

    After:

    image

    So the problem happens only when there are multiple books selected.

  • Dave Hooton
    Dave Hooton MVP Posts: 36,308

    I understand but it's still crude and dangerous! It isn't clear that it is intended to replace tags when the heading reads "Add these tags to all" and it doesn't display any of the original tag values. My suggestion should clarify the functions allowed and permit safer operation.

    Dave
    ===

    Windows 11 & Android 13

  • Rosie Perera
    Rosie Perera Member Posts: 26,194 ✭✭✭✭✭


    I understand but it's still crude and dangerous! It isn't clear that it is intended to replace tags when the heading reads "Add these tags to all" and it doesn't display any of the original tag values. My suggestion should clarify the functions allowed and permit safer operation.


    I wasn't really trying to replace existing tags. I had typed a new tag, then realized I'd made a typo in it and wanted to fix it, but it added it as a second tag.

    I wholeheartedly agree that this feature is crude and dangerous. I don't think Logos should allow there to be any features that are crude and dangerous. Your suggestion sounds like a good one. I don't know if it includes a fix to this problem, but point 1 would certainly have helped me to see right away that it had happened instead of discovering it only when I visited the info panel of one of the books in question.

  • Rosie Perera
    Rosie Perera Member Posts: 26,194 ✭✭✭✭✭


    I got caught with wanting to Clear tags, knowing it would clear EVERY tag value, in order to replace them with a new tag value. As soon as I cleared them the books disappeared from the Library list and I had to select them manually, hoping I would remember all13 resources!


    Dave, I discovered a workaround for this problem, but it relies on another bug! I've since reported the other bug (http://community.logos.com/forums/t/14145.aspx), but pled with Logos not to fix it until they fix this problem. The work around is to click the My Tags column to sort by tag. Then expand the section for the tag you want to change, select all the books in that section, and click Clear tags. The bug is that the Library won't refresh now -- it still shows the books under the expanded heading of the old tag that doesn't exist anymore, and they are still selected. This is very convenient, because then you can enter your new tag. However it's probably not how the program should work. You have to click the My Tags column heading twice to resort in increasing alphabetical order and refresh the library.

    UPDATE: Caveat: "Clear tags" removes all tags, not just the tag of the section. So this method would only be useful for changing a tag when you know it is the only tag in use on those books. Or else you'd have to remember the other ones that were there and put them back in.

  • MJ. Smith
    MJ. Smith MVP Posts: 55,407

    click Clear tags

    I've not tried this. Does it remove all tags or only the tag you've expanded?

    Orthodox Bishop Alfeyev: "To be a theologian means to have experience of a personal encounter with God through prayer and worship."; Orthodox proverb: "We know where the Church is, we do not know where it is not."

  • Rosie Perera
    Rosie Perera Member Posts: 26,194 ✭✭✭✭✭

    MJ. Smith said:


    click Clear tags

    I've not tried this. Does it remove all tags or only the tag you've expanded?


    It removes all tags. (EDIT: I hadn't tried it yet when I initially posted that, but I guessed it was the case, and just tried it now and it is indeed the case.) So this method could only be used for changing a tag when you knew it was the only tag in use on those books. I meant to add a caveat about this when I was writing my previous post. I'll go back and edit it now.

  • Dave Hooton
    Dave Hooton MVP Posts: 36,308

    Dave, I discovered a workaround for this problem, but it relies on another bug!

    Why did you report the bug[^o)]

    The Library shouldn't resort until I've closed the Information panel, signalling that I've finished making changes.

    UPDATE: Caveat: "Clear tags" removes all tags, not just the tag of the section. So this method would only be useful for changing a tag when you know it is the only tag in use on those books. Or else you'd have to remember the other ones that were there and put them back in.

    I'd carefully guarded against that eventuality but was caught out by what happened after the CLEAR!

    Dave
    ===

    Windows 11 & Android 13

This discussion has been closed.