Bug 4.1 RC 2: Phase search returns incorrect results when due to hover text.

Mark Barnes
Mark Barnes Member Posts: 15,432 ✭✭✭

To reproduce:

  1. Search for the phrase "new song" in the ISBE.
  2. You'll see that most of the results actually are "NEB Song". This isn't a result of matching all word forms, but because the letters NEB have the hovertext "New English Bible".

This shouldn't match "new song", because clearly the phrase "new song" doesn't occur here.

This is my personal Faithlife account. On 1 March 2022, I started working for Faithlife, and have a new 'official' user account. Posts on this account shouldn't be taken as official Faithlife views!

Comments

  • Dave Hooton
    Dave Hooton MVP Posts: 36,114

    That happens with "All Text". You need the Field "Surface Text" to avoid searching in footnotes and popup abbreviations.  The issue then lies with books that do have search fields or do not have "Surface Text".

    Dave
    ===

    Windows 11 & Android 13

  • Mark Barnes
    Mark Barnes Member Posts: 15,432 ✭✭✭

    Thanks Dave. I understand the workaround, but we shouldn't have to workaround.

    This is my personal Faithlife account. On 1 March 2022, I started working for Faithlife, and have a new 'official' user account. Posts on this account shouldn't be taken as official Faithlife views!

  • Dave Hooton
    Dave Hooton MVP Posts: 36,114

    Thanks Dave. I understand the workaround, but we shouldn't have to workaround.

    After looking more closely, I agree.

    In ESVSB  there is a common phrase "the ESV Study Bible",
    where ESV has
    hover text "English Standard Version".  I get results searching for "English
    Study"
    but "the English" does not return results in that
    phrase!

    In TDNT "the more common mid., is a new" occurs in Vol 1, p.19, where mid has hover text "middle". If I
    search for:-

    • "common middle" there is no result, but
    • common BEFORE 1 words middle produces the hit, whilst
    • "middle
      is"
      produces hits (which are the same as middle BEFORE 1 word is)

    The fault lies with the phrase search as we expect the result to match each word without any intervening words!

    BTW I'm sure you understood that "the issue then lies with books that do have search fields" should have been "the issue then lies with books that do not have search fields"!

    Dave
    ===

    Windows 11 & Android 13

This discussion has been closed.