Design Bugs L8.3 B1: Add Highlight

The new beta adds the "add highlight" to the right-click menu, which probably is a good thing for many users (I personally prefer to highlight with keyboard keys - why do I tell this? It will become clear in a sec). There seem to be at least two issues with the new functionality:

  • It seems the functionality was copied almost fully from "Add Note" - and thus it brings up the Notes tool which it shouldn't:
    • Steps to reproduce: Open a resource
    • Select text in the resource, use right-click menu and Add Highlight
    • Result: Highlight is applied and the Notes tab will get focus (as if to accept input - which is not usual for highlights). If the Notes tab was not open, it will be opened to get focus (irritating for users who work with carefully designed layouts). If the Notes tab was sitting back in the same panel as the resource, it will be brought forward to get focus i.e. it will overlay the resource (irritating for users who just read in a resource, highlighted something and then the resource simply vanishes from sight and they have to deal with a Notes tab they have no use for in the moment)!
    • Expected result: Highlight is applied, period.

  • The functionality "add highlight" seems to use the most recent highlight employed by this functionality or the Tools / Highlighting tab. This is not necessarily the very last highlight applied (as I had understood the Release Notes) and is very confusing. 
    • Steps to reproduce: Open a resource
    • Open Tools/Highlighting, making sure a keyboard shortcut is assigned to a highlight, e.g. B to Solid Colors / Blue
    • Use another highlighter to highlight any text in the resource, say Solid Colors / Orange 
    • if you like, work some minutes or hours in Logos without using the Tools / Highlighting panel, you may close it, forget it, even highlight a lot of stuff with keyboard shortcuts. You might become fully unaware of what the last used highlight even was. But you can just as well disregard this step.
    • Select text in the resource, hit B thus highlighting in Blue which is the very last used highlight
    • Select text in the resource, use right-click menu and Add Highlight
    • Result: Orange (initial reaction: huh? why this?)
    • Expected Result: Blue - the last used highlight

Have joy in the Lord! Smile

Comments

  • NB.Mick
    NB.Mick MVP Posts: 15,972

    Since the post went unacknowledged and drops off into oblivion, just a quick update that both bugs persist in L8.3 Beta 2 (which was to be expected)  

    Have joy in the Lord! Smile

  • Philana R. Crouch
    Philana R. Crouch Member, Logos Employee Posts: 4,597

    NB.Mick said:

    Since the post went unacknowledged and drops off into oblivion, just a quick update that both bugs persist in L8.3 Beta 2 (which was to be expected)  

    Hi NB.Mick,

    I'm still looking into the first issue. But the second issue is behaving as expected. The highlighting style is pulled from what is used with CMD/CTRL+K, like old notes, it ignores the style used by an assigned keyboard shortcut. 

  • NB.Mick
    NB.Mick MVP Posts: 15,972

    the second issue is behaving as expected. The highlighting style is pulled from what is used with CMD/CTRL+K, like old notes, it ignores the style used by an assigned keyboard shortcut.

    I must admit I wasn't aware of that keyboard shortcut and its behavior in L7 - and I was not sure this was an implementation bug, thus I named it a design bug, and now I'd call it a longstanding design bug: why would the feature to apply the last used highlight only utilize the highlight applied through some, but not all highlighting functionality on this same device? Maybe time to rethink the design (I can live with it not being on the top three priority positions).

    By the way: Highlighting, through any functionality, has become awfully slow. And highlighting in a new book now takes very long to reset the Visual filter to actually show the highlight assigned to No Notebook (I made three highlights, didn't see any, opened VF to see whether we might have a regression, started to think about filing a bug report and then seeing the VF change and the highlights appear)     

    Have joy in the Lord! Smile

  • Philana R. Crouch
    Philana R. Crouch Member, Logos Employee Posts: 4,597

    NB.Mick said:

    By the way: Highlighting, through any functionality, has become awfully slow. And highlighting in a new book now takes very long to reset the Visual filter to actually show the highlight assigned to No Notebook (I made three highlights, didn't see any, opened VF to see whether we might have a regression, started to think about filing a bug report and then seeing the VF change and the highlights appear)     

    I've filed a bug report for this.

  • Philana R. Crouch
    Philana R. Crouch Member, Logos Employee Posts: 4,597

    NB.Mick said:

    • It seems the functionality was copied almost fully from "Add Note" - and thus it brings up the Notes tool which it shouldn't:

    This has been changed in 8.3 RC 1 to follow the behavior of CMD/CRTL+K which applies the highlighting style, but does not open the Notes Tool.

  • NB.Mick
    NB.Mick MVP Posts: 15,972

    applies the highlighting style, but does not open the Notes Tool

    Thanks!

    Have joy in the Lord! Smile