BUG: Annotation loses label when moved from one note file to another note file (Win 6.0a Beta 2 6.0.

Tim Hensler
Tim Hensler Member Posts: 1,532 ✭✭✭

Repeatable problem:

  1. Mark a text in NASB with a highlight style that has a label
  2. Check the annotation in note file A to confirm it has a label
  3. Hover over the text in NASB to confirm it has a label associated with it
  4. Move the annotation from note file A to note file B
  5. Check annotation in note FIle B - it does not have a label
  6. Hover over the text in NASB - it no longer has a label associated with it
  7. Make sure note file A has focus
  8. Press Ctrl-Z to undo the move (puts annotation back to note file A and leaves the copy in note file B)
  9. Check both annotations and find neither has the label associted with them
  10. Hover over the text in NASB - it too still does not have a label associated with it
  11. Make sure note file B has focus
  12. Press Ctrl-Z to undo the move (removes the annotation from note file B)
  13. Check the annotation in note file A - no label
  14. Hover over the text in NASB - no label

Comments

  • Bradley Grainger (Logos)
    Bradley Grainger (Logos) Administrator, Logos Employee Posts: 11,958

    I've reported this bug also.

  • Dylan Rondeau
    Dylan Rondeau Member, Logos Employee Posts: 1,401

    This should be fixed in 6.0b Beta 2.

    Dylan Rondeau, Software Tester

    Enable Logging: Mac | Windows (Right-click "Save As...")

  • Tim Hensler
    Tim Hensler Member Posts: 1,532 ✭✭✭

    This does NOT work correctly.  When I do step 4, the text in NASB looses both the label and the highlight formatting, but the note in note file B still has the label associated with it.  When I undo the move (putting the note back into note file A), the text in NASB regains both the label and the highlight formatting.

  • Dylan Rondeau
    Dylan Rondeau Member, Logos Employee Posts: 1,401

    This does NOT work correctly.  When I do step 4, the text in NASB looses both the label and the highlight formatting, but the note in note file B still has the label associated with it.  When I undo the move (putting the note back into note file A), the text in NASB regains both the label and the highlight formatting.

    What I verified was fixed was that the label wasn't lost when moving from note A to note B. I'll reactivate/make a new case for the moved highlight not appearing in the resource - sorry for that.

    Interestingly, after pressing Ctrl+Z to replace the annotation in note A and leaving the copy in note B, you can delete the annotation from note A and the highlight/label will remain in the NASB (the desired behavior). I'm not sure why that is.

    Dylan Rondeau, Software Tester

    Enable Logging: Mac | Windows (Right-click "Save As...")

  • Seth Copeland
    Seth Copeland Member, Logos Employee Posts: 232

    This does NOT work correctly.  When I do step 4, the text in NASB looses both the label and the highlight formatting, but the note in note file B still has the label associated with it.  When I undo the move (putting the note back into note file A), the text in NASB regains both the label and the highlight formatting.

    In my test, the highlight/label is not truly lost, but the resource display was refreshed to indicate the note was removed from the one document, but not refreshed to indicate it had been added to the other.

    When I close and reopen the resource, the highlight and label both appear to still be intact.
    Can you verify the same behavior?

    -Seth Copeland

  • Tim Hensler
    Tim Hensler Member Posts: 1,532 ✭✭✭

    Thank you, Dylan.

    Yes, there is some strange behavior going on.  After I moved the note to file B and then did Ctrl+Z (so the note was in both files) I noticed the text in the resource was tagged twice (overlapping one another).  When I deleted the note in file B, then there was one tag on the resource text.  I didn't have time to test and document all the combinations (sorry) but am glad you were able to reproduce the problem.

  • Tim Hensler
    Tim Hensler Member Posts: 1,532 ✭✭✭

    Can you verify the same behavior?

    Hi Seth,

    I may not be able to retest until tonight or tomorrow night (sorry), but will test and report as soon as I can.  Thank you for your help.

  • Seth Copeland
    Seth Copeland Member, Logos Employee Posts: 232

    I may not be able to retest until tonight or tomorrow night (sorry), but will test and report as soon as I can.  Thank you for your help.

    I just pushed a fix that should make it into the next beta. Thanks a lot Tim for finding and reporting these issues! It is much appreciated.

    -Seth Copeland

  • Tim Hensler
    Tim Hensler Member Posts: 1,532 ✭✭✭

    I just pushed a fix that should make it into the next beta.

    Thank you, Seth.  In that case, I won't test the current state unless you indicate I need to. I'll test the fix when it is released.

  • Dave Hooton
    Dave Hooton MVP Posts: 35,683

    I just pushed a fix that should make it into the next beta.

    Is this case also covered by the fix?

    Dave
    ===

    Windows 11 & Android 13

  • Tim Hensler
    Tim Hensler Member Posts: 1,532 ✭✭✭

    I just pushed a fix that should make it into the next beta.

    Is this case also covered by the fix?

    Hi Seth and Dylan - I tested the fix for the problem described on this post and found it is working properly now - thank you.

    Hi Dave - I have not had the problem described in the other post and did not test for it.

  • Dave Hooton
    Dave Hooton MVP Posts: 35,683

    Hi Dave - I have not had the problem described in the other post and did not test for it.

    Thanks Tim

    Dave
    ===

    Windows 11 & Android 13

  • Dylan Rondeau
    Dylan Rondeau Member, Logos Employee Posts: 1,401

    I just pushed a fix that should make it into the next beta.

    Is this case also covered by the fix?

    Hi Seth and Dylan - I tested the fix for the problem described on this post and found it is working properly now - thank you.

    This is fixed in 6.0b, on the stable channel.

    Dylan Rondeau, Software Tester

    Enable Logging: Mac | Windows (Right-click "Save As...")