[ACK] Bug (known or new?): 6.1 Beta 3 Factbook phrase search broken

Factbook treats a search phrase in quotation marks (such as "law of christ", "law of the gospel") wrongly as an OR search (executing a search for e.g. law OR of OR christ), coming up with ridiculous results.

See the results of Dave in this thread: https://community.logos.com/forums/p/99884/690563.aspx#690563  

Have joy in the Lord! Smile

Comments

  • NB.Mick
    NB.Mick MVP Posts: 16,333

    just to let this one not fall through the cracks: 

    The bug still persists in beta 6 - these three are false positives:

    Have joy in the Lord! Smile

  • Dave Hooton
    Dave Hooton MVP Posts: 36,359

    To be clear, the problem lies with Factbook Search. Factbook itself doesn't do anything with a phrase. Without quotes Factbook Search produces fewer results than Factbook.

    I don't remember if the issue was raised much earlier than this but it clearly has to be resolved.

    Dave
    ===

    Windows 11 & Android 13

  • NB.Mick
    NB.Mick MVP Posts: 16,333

    This sad error went live with L6.1. Saw it today when I tried to look for a spelling error in the already unfortunate Factbook article on Aristotle:

     

    What's perhaps even worse: the one Factbook article that actually does contain the phrase is not among the 28 false positive hits. [:(] 

    Have joy in the Lord! Smile

  • NB.Mick
    NB.Mick MVP Posts: 16,333

    I didn't expect this to have changed in L6.2 Beta 1 (after all it wasn't even acknowledged, let alone promised to be changed and then reported as solved in the Release Notes), nevertheless I think the inconsistent treatment of Factbook searches as opposed to other searches in Logos is a point of concern and therefore I'd like to check up on this thread - hoping for something like "this is on our list" or even "this is by design, live with it!" rather than chirping cicadas ...

    This is the picture under 6.2 Beta 1

    Have joy in the Lord! Smile

  • NB.Mick
    NB.Mick MVP Posts: 16,333

    just to not let this be forgotten: all three issues are still present in L6.3 RC 1

    (thanks Rosie for digging this up in another thread)

    Have joy in the Lord! Smile

  • Eli Evans (Logos)
    Eli Evans (Logos) Member, Logos Employee Posts: 1,411

    Hi, all. Factbook search does not search FB content, but only headings. So that part is by design (for now).

    What the Factbook section of Everything Search actually does is return exactly the same set of suggestions as you would get if you typed those words into the auto-complete location box at the top of Factbook.There is already an open bug case for making better multi-word suggestions in the auto-completer in Factbook.

    Thanks!

  • Rosie Perera
    Rosie Perera Member Posts: 26,194 ✭✭✭✭✭

    Eli Evans said:

    Hi, all. Factbook search does not search FB content, but only headings. So that part is by design (for now).

    What the Factbook section of Everything Search actually does is return exactly the same set of suggestions as you would get if you typed those words into the auto-complete location box at the top of Factbook.There is already an open bug case for making better multi-word suggestions in the auto-completer in Factbook.

    Thanks!

    Eli, you overlooked the bug report about the typo "hundereds" in Factbook which cannot be reported via Report Typo. See Bug #3 in the image in this post by NB.Mick.

    NB.Mick, if he doesn't answer back, you could email that to data@logos.com.

  • Dave Hooton
    Dave Hooton MVP Posts: 36,359

    Eli Evans said:

    What the Factbook section of Everything Search actually does is return exactly the same set of suggestions as you would get if you typed those words into the auto-complete location box at the top of Factbook.

    Like this?

        
      

    Results are the same until "Christ as King". Factbook (tool) clearly has fewer results.

    The respective results are exactly the same for "law christ" (Search) and law Christ (tool) i.e. Auto-completer picks on the second word "Christ".

    Dave
    ===

    Windows 11 & Android 13

  • Eli Evans (Logos)
    Eli Evans (Logos) Member, Logos Employee Posts: 1,411

    Eli, you overlooked the bug report about the typo "hundereds" in Factbook which cannot be reported via Report Typo. See Bug #3 in the image in this post by NB.Mick.

    I noted it, but didn't post back, sorry. data@logos.com is the best way to get those reported, though.

  • Eli Evans (Logos)
    Eli Evans (Logos) Member, Logos Employee Posts: 1,411

    Results are the same until "Christ as King". Factbook (tool) clearly has fewer results.

    That's ... really weird. AFAIK, the Factbook search is supposed to be running literally the same code as the autocompleter. #heavy-sigh

    I'll file it. Thanks!

  • Andrew Batishko
    Andrew Batishko Member, Community Manager, Logos Employee Posts: 5,584

    Dave, all of the auto-completers limit the number of results displayed per suggestion type (as indicated by the icon and the subtitle after the main text). You will notice that exactly 6 topics are displayed in the Factbook suggestion list. That is the limit number for that auto-completer.

    Andrew Batishko | Logos software developer

  • Dave Hooton
    Dave Hooton MVP Posts: 36,359

    Dave, all of the auto-completers limit the number of results displayed per suggestion type

    Thanks for that. But you get unexpected results when you try to improve the selection:-

    It should regard the entry as part of a phrase.

    Dave
    ===

    Windows 11 & Android 13

  • Andrew Batishko
    Andrew Batishko Member, Community Manager, Logos Employee Posts: 5,584

    Thanks for this specific example, Dave. I'll write up a case to take a look at this.

    We don't want to just always treat this kind of a thing as a phrase search. Otherwise we wouldn't come back with the suggestion "Asa (king of Judah)" when, for example, the user types in "Asa Judah".

    I think it's just a problem with prioritization causing things not to come back in the limited result list. Your specific example actually has 574 different possible suggestions.

    Andrew Batishko | Logos software developer

  • Andrew Batishko
    Andrew Batishko Member, Community Manager, Logos Employee Posts: 5,584

    I was also unable to find a case for the original post, so I created one for that too.

    Andrew Batishko | Logos software developer

  • NB.Mick
    NB.Mick MVP Posts: 16,333

    I was also unable to find a case for the original post, so I created one for that too.

    Thanks. Please have in mind that we knew much less back then about how Factbook search is supposed to work (as per your current design) - regarding the OR my description may have been wrong then, at least it seems to be now.

    Under 6.3, I think multiple words fare sometimes better than lookup search (i.e. more precise), whereas phrases - used by users to explicitly force a different, narrower, more precise match - fall into the unfortunate lookup mode which is less precise and seemingly takes only the last word of the phrase into account.  

    Have joy in the Lord! Smile

  • Dave Hooton
    Dave Hooton MVP Posts: 36,359

    We don't want to just always treat this kind of a thing as a phrase search. Otherwise we wouldn't come back with the suggestion "Asa (king of Judah)" when, for example, the user types in "Asa Judah".

    That was what I meant by "part of a phrase". Currently an entry of Asa Judah totally ignores Asa!

    Dave
    ===

    Windows 11 & Android 13

  • Andrew Batishko
    Andrew Batishko Member, Community Manager, Logos Employee Posts: 5,584

    That was what I meant by "part of a phrase". Currently an entry of Asa Judah totally ignores Asa!

    I understand.

    Both Factbook and Search generate the same list of results. Factbook trims the list down to the highest priority matches. As you can see from the screenshot below, Asa does actually show up on page 2 of the results, but it's not properly getting prioritized, so it gets trimmed out in Factbook.

    Andrew Batishko | Logos software developer