"Invalid color value provided to Reftagger. Must be in hex format."

Hello,

I am seeing an error in my browser console:

Invalid color value provided to Reftagger. Must be in hex format.

Here is my JS code:

	var refTagger = {
		settings: {
			bibleVersion: "NIV",			
			roundCorners: true,
			socialSharing: ["google"],
			tagChapters: true,
			noSearchClassNames: ["grade"],
			customStyle : {
				heading: {
					backgroundColor : "#91AB1D",
					color : "#000000"
				},
				body   : {
					color : "#000000"
				}
			}
		}
	};
	(function(d, t) {
		var n=d.querySelector("[nonce]");
		refTagger.settings.nonce = n && (n.nonce||n.getAttribute("nonce"));
		var g = d.createElement(t), s = d.getElementsByTagName(t)[0];
		g.src = "https://api.reftagger.com/v2/RefTagger.js";
		g.nonce = refTagger.settings.nonce;
		s.parentNode.insertBefore(g, s);
	}(document, "script"));

Any idea what's causing that error? Thanks

Find more posts tagged with

Comments

MJ. Smith

weekly bump to give the post visibility and, hopefully, an answer 2

Ali Pope

https://community.logos.com/discussion/comment/1214250#Comment_1214250

Hi John, we apologize for the issue you are experiencing.

It is possible that the error message was prompted by an invalid option from your settings. Can you please reach out to us at support@faithlife.com so we can take a closer look at this.

Thanks in advance!

John Percival

https://community.logos.com/discussion/comment/1217275#Comment_1217275

Hi Alli, thanks for the message. It's been a couple of weeks since I sent in the email - any chance you could see how it's getting on please? Thanks!

Ali Pope

https://community.logos.com/discussion/comment/1219434#Comment_1219434

Hi John. Based on what we can see, you must have provided an invalid option for the custom color. The error indicates it should be in hex format, so you will need to fix this input. This should be a setting that you set.

John Percival

https://community.logos.com/discussion/comment/1219551#Comment_1219551

Thanks Ali, you can see my JS code above. It was generated by the reftagger customisation form on the site.

I can't see any invalid hex codes in the colours. Can you be any more specific?

Aaron Blumer

I am having this problem as well. ... and my colors are also in hex.

If it matters: the site is Drupal 9.4.x, and the colors do display properly despite the console error indicating they aren't valid.

Aaron Blumer

https://community.logos.com/discussion/comment/1239067#Comment_1239067

There's a place in the code (javascript, I gather?) where a color appears to be converting a color number using what looks to me like some regex. My guess is there's a bug there. This is from the browser console...

return t.test(e)?e.replace(/^#(\w)(\w)(\w)$/,"#$1$1$2$2$3$3"):(window.console&&window.console.warn&&window.console.warn

("Invalid color value provided to Reftagger.

So maybe the script assumes the color is not hex and tries to convert it to hex. I'll see if I can figure it out.

Edit to update: I don't understand JS well enough to figure out what's happening there. I removed the custom styles section from the generated code and that stopped the error. I'm using Drupal so the custom colors can be added directly to the theme CSS anyway. (Or at least that seems to be working so far.)

John Percival

https://community.logos.com/discussion/comment/1241004#Comment_1241004

It's not easy with the minified Javascript, but I think the change needed is:

From:

c=r(t.body.moreLink&&t.body.moreLink.color)

To:

c=t.body.moreLink&&r(t.body.moreLink.color)

Please could someone at Faithlife test, review and deploy?

(Reasoning: the r() function seems to test for a valid hex color format, so it needs to be passed a parameter that is a color, not a result from a logical && operation)

Adam Borries (Logos)

https://community.logos.com/discussion/comment/1243286#Comment_1243286

Thanks, John. After looking at it more closely, the team thinks we shouldn't be logging that warning in that configuration. This is opportunity for some code clean up on our side; in the meantime, you shouldn't see any broken functionality because of it.

John Percival

https://community.logos.com/discussion/comment/1243459#Comment_1243459

Thanks Adam. I know the warning isn't affecting functionality, but there is just a little bit of me that dislikes loose ends - such as warning messages. Hah, it's just the way I'm wired.

Anyway, if you did a quick fix on this little issue it would make me happy. And if this sparks a wider clean up then that's fine, I just hope that by pointing out a specific fix for this issue that it isn't submerged into a lengthy code rewrite that drags on for ages. Thanks for taking a look at this, much appreciated