BUG: Removing a Label definition does not remove the label from highlighting
See the original post for this issue.
Steps to reproduce:
- Create a new Highlighting style (testlabel) e.g. one with a distinct underline.
- In Labeling, tick the first box and supply the same name as the style (testlabel).
- Do not tick the Prompt box
- Apply the highlight style to three sections of text in a book (3 highlights).
- Run a Search for label:testlabel
- You should get 3 results
- In Labeling untick the first box (trying to remove only the label definition)
- Run a Search for label:testlabel
- Bug: you still get 3 results
The highlights are still present in the Notes tool, together with the user Label. I expected the Label to be removed.
EDIT: after removing, the label definition was not sync'd to other installations i.e. the label definition was not affected elsewhere.
Dave
===
Windows 11 & Android 13
Comments
-
Also, shouldn't it be the case that if you delete the Label in Highlights that it should also delete the highlights, in Notes Highlights, that was created when the Label was created?
xn = Christan man=man -- Acts 11:26 "....and the disciples were first called Christians in Antioch".
Barney Fife is my hero! He only uses an abacus with 14 rows!
0 -
Also, shouldn't it be the case that if you delete the Label in Highlights that it should also delete the highlights, in Notes Highlights, that was created when the Label was created?
One thing at a time, xnman. If you wanted that to happen you should have deleted the highlights.
Removing the label definition should not affect the highlighting.
Dave
===Windows 11 & Android 13
0 -
The highlights are still present in the Notes tool, together with the user Label. I expected the Label to be removed.
This is the expected behavior. The "implies a label" portion of the highlighting definition will only cause a label to be added to new notes created with this highlighting style. Labels are not a strict part of the highlighting style. Similarly you can switch the highlighting style of an existing note to one that "implies a label", but doing so will not add a label to that note. You can also add labels to (or remove them from) an existing note, which you couldn't do if it was strictly tied to the highlighting style.
Andrew Batishko | Logos software developer
0 -
This is the expected behavior.
I think I see the logic, but if it no longer "implies" a label why should that remain with the highlight?
One can add a label with the same name to other notes/highlights in the Notes tool, but that is not "implied" and why doesn't it recognise the attributes of a defined label i.e. where does a label definition exist?
Dave
===Windows 11 & Android 13
0 -
Regardless of the "implies" terminology in the UI, the label data on notes has no connection to the label settings on a highlighting style. The label settings on the highlighting style are used only when first creating a new note. There is no requirement that the labels on a note match in any way the labels defined on the highlighting style currently in use by the note. I think the "implies" label was attempting to call out the fact that there is no requirement that the label (and only that label) exist on notes using that highlighting style.
Attempting to delete the labels from notes with that style would risk destroying explicitly created labels (as opposed to just destroying labels that were automatically added by the style), which is something we take great pains to avoid.
Andrew Batishko | Logos software developer
0 -
For what it's worth, it works as I expect.
Orthodox Bishop Alfeyev: "To be a theologian means to have experience of a personal encounter with God through prayer and worship."; Orthodox proverb: "We know where the Church is, we do not know where it is not."
0 -
I think the "implies" label was attempting to call out the fact that there is no requirement that the label (and only that label) exist on notes using that highlighting style.
I had observed that. But I thought that a defined label should keep the attributes and behaviour defined by the highlighting style when used on another highlight/note?
Dave
===Windows 11 & Android 13
0 -
But I thought that a defined label should keep the attributes and behaviour defined by the highlighting style when used on another highlight/note?
I'm not entirely clear on what you are asking, but nothing stops you from editing the label that was added to a new note created from a highlight that specifies a label. You could change it completely if you wanted, replacing all the properties, or even just deleting it.
Essentially, there is nothing in the application that enforces label structure.
Andrew Batishko | Logos software developer
0 -
Essentially, there is nothing in the application that enforces label structure.
The label Prompt to enter attributes is enforced for the defining highlight. I'm wondering why it could not be enforced for other Notes/Highlights.
Dave
===Windows 11 & Android 13
0 -
Essentially, there is nothing in the application that enforces label structure.
The label Prompt to enter attributes is enforced for the defining highlight. I'm wondering why it could not be enforced for other Notes/Highlights.
From the introduction of labels, the highlight provided the definition of the label, and I name the label the same as the highlight. Then it was introduced to the Notes tool, so you could attach a label to any note/highlight. But it meant there was no definition maintained in the software, and no enforcement of existing label attributes.
Dave
===Windows 11 & Android 13
0 -
The label Prompt to enter attributes is enforced for the defining highlight.
It's not really enforcing anything. Once that popup appears, you can freely delete, add, or change any of the properties defined by the highlighting style. It's just giving you a starting point.
Perhaps you are suggesting that when you change a note to use that highlighting style that it prompt again to add the label. Even if that were to be done, there is still nothing that enforces that the label set on the note look anything like what is defined by the style.
Andrew Batishko | Logos software developer
0 -
From the introduction of labels, the highlight provided the definition of the label, and I name the label the same as the highlight. Then it was introduced to the Notes tool, so you could attach a label to any note/highlight. But it meant there was no definition maintained in the software, and no enforcement of existing label attributes.
Even from its introduction, the definition provided by the style was not a strict requirement, and nothing has ever been done to enforce that the label defined by the style exists exactly as defined on any note with that highlighting style.
Andrew Batishko | Logos software developer
0 -
I get how you want it to work. It's just not how the system was designed from the start.
Andrew Batishko | Logos software developer
0 -
I get how you want it to work. It's just not how the system was designed from the start.
Thank you for clarifying.
Dave
===Windows 11 & Android 13
0 -
I get how you want it to work. It's just not how the system was designed from the start.
If anyone at FL decides to do a complete rebuild of the program, consider this to be avid encouragement. [<:o)] Logos is so persistently broken for almost every task I attempt that I can hardly use it for anything other than an e-reader. Literally ANY condition would be better than the status quo. I can't recall even one time in the last 3-4 years where I got 5 straight minutes of productive use out of the program. I used to log 12-20 hours per day of use. Nothing in my life has disappointed me as much as Logos has.
ASUS ProArt x570s Creator, AMD R9 5950x, HyperX 64gb 3600 RAM, ASUS Strix RTX 2080 ti
"The Unbelievable Work...believe it or not." Little children...Biblical prophecy is not Christianity's friend.
0
