BUG: Visual Filter for Bible References

Dave Hooton
Dave Hooton Member, MVP Posts: 35,672 ✭✭✭
edited November 21 in English Forum

If I have a VF for bible:Gal-Col in a commentary, it will highlight all text with those milestones and highlight appropriate references outside those books. The Panel menu initially selects Match all word forms and MER and nothing changes unless you deselect MER first and then the Match...

Thereafter, I can select both of them without changing the highlighting, but if I then deselect the Match... the milestones become highlighted again. Then selecting the Match... will remove the milestone highlights!

Logos 31.3 with my Search panels set to Narrow Reference Matching.

Dave
===

Windows 11 & Android 13

Tagged:

Comments

  • Matt Mattox (Faithlife)
    Matt Mattox (Faithlife) Member, Logos Employee Posts: 902

    Logos 31.3 with my Search panels set to Narrow Reference Matching.

    I can replicate the behavior in the visual filter within a commentary, just not 100% sure what you are doing in your search panel. When you can, could you upload a screenshot of your search panel to help us see what you are doing within the search panel. Thanks!


  • Dave Hooton
    Dave Hooton Member, MVP Posts: 35,672 ✭✭✭

    Logos 31.3 with my Search panels set to Narrow Reference Matching.

    I can replicate the behavior in the visual filter within a commentary, just not 100% sure what you are doing in your search panel. When you can, could you upload a screenshot of your search panel to help us see what you are doing within the search panel. Thanks!

    image
    The options in the Panel menu (three vertical dots) of the screenshot are the ones I'm using whilst watching the effect in the Commentary.

    Dave
    ===

    Windows 11 & Android 13

  • Matt Mattox (Faithlife)
    Matt Mattox (Faithlife) Member, Logos Employee Posts: 902

    Thanks, I have everything I need to write up a case. 

  • Adam Borries (Logos)
    Adam Borries (Logos) Member, Logos Employee Posts: 872

    Hi, Dave, 

    Thanks for the report, but we believe this is working as expected.

    When you search for Bible reference (e.g., bible:Gal-Col) and select Match Equivalent References, it is designed to match on both reference and the text in the milestone. (This is primarily so that when a user searches for a Bible reference in Bible search, it will return the verse itself, and not only the references to it in footnotes, etc.)

    The issue is that when you check or uncheck MRE in the VF document, the highlighting doesn’t update immediately when you have the resource open. (I don’t think the “Match all words” setting has anything to do with it.) It does, however, respect the MRE setting correctly when you close and re-open the book, or turn the visual filter off and on again in the setting. If I’m not mistaken, this is related to a performance optimization, so that we can open the book more quickly when there is an performantly expensive visual filter search.

  • Dave Hooton
    Dave Hooton Member, MVP Posts: 35,672 ✭✭✭

    When you search for Bible reference (e.g., bible:Gal-Col) and select Match Equivalent References, it is designed to match on both reference and the text in the milestone.

    Understood.

    The issue is that when you check or uncheck MRE in the VF document, the highlighting doesn’t update immediately when you have the resource open. (I don’t think the “Match all words” setting has anything to do with it.) It does, however, respect the MRE setting correctly when you close and re-open the book, or turn the visual filter off and on again in the setting.
    1. The MER setting sticks when deselected, even if the VF is turned off and on in the book
      1. i.e. MER highlighting turns off then on again in the book whilst MER is deselected in the VF. 
    2. The MER highlighting turns off when any [Match...] is selected in the VF.
    3. It does not highlight when MER is selected; but
      1. it does so when the [Match...] is deselected (whether immediately or after waiting)
    4. The cycle repeats from Step 1.

    Logos 33.1

    Dave
    ===

    Windows 11 & Android 13